BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Structure_Engine: Add required methods for Cassette and BuiltUpRibbed properties #3311

Closed IsakNaslundBh closed 5 months ago

IsakNaslundBh commented 5 months ago

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1604

Issues addressed by this PR

Adds required methods for new Cassette and BuiltUpRibbed properties:

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM/Structure_oM/%231604-AddCassetteAndBuiltUpRibProperties?csf=1&web=1&e=0MwLH7

Changelog

Additional comments

IsakNaslundBh commented 5 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 5 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
IsakNaslundBh commented 5 months ago

@BHoMBot check serialisation @BHoMBot check null-handling

bhombot-ci[bot] commented 5 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `serialisation` - check `null-handling`
peterjamesnugent commented 5 months ago

@BHoMBot check required

bhombot-ci[bot] commented 5 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 8 requests in the queue ahead of you.
bhombot-ci[bot] commented 5 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
@IsakNaslundBh just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM
bhombot-ci[bot] commented 5 months ago
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM
bhombot-ci[bot] commented 5 months ago
The check `null-handling` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `serialisation` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `versioning` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
peterjamesnugent commented 5 months ago

@BHoMBot check unit-tests @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 5 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests` - check `ready-to-merge`
IsakNaslundBh commented 5 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 5 months ago
@IsakNaslundBh I'm sorry, but I am not authorised to take that instruction from you.
peterjamesnugent commented 5 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 5 months ago
@peterjamesnugent I'm sorry, but I am not authorised to take that instruction from you.
FraserGreenroyd commented 5 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.