search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

ISetGeometry deleted #3314

Open johannaisak opened 5 months ago

johannaisak commented 5 months ago

Description:

I use this method all the time to manipulate analysis models. Please can we reinstate it? Or alternatively a specific SetGeometry for Bars?

image

FraserGreenroyd commented 5 months ago

Hi @johannaisak , based on this PR which removed ISetGeometry, the method was calling to a SetGeometry method via the TryRunExtension (see below/files changed on the link).

image

This suggests that there is a method for SetGeometry that will accept a Bar if it was working previously. I've tried looking for it but I can't work out which one it would be, so my recommendation would be to drag right out of a bar component and let the wire search find it for you (as it should come up with the option that accepts a Bar first).

johannaisak commented 4 months ago

Thanks @FraserGreenroyd you're right this is the component, searching for "SetGeometry el.." brings it up. Not sure why the component calls it ISetGeometry, the search result just says SetGeometry. It would be great if this search result could come up if you search for "SetGeometry bar" as well but perhaps that is not possible?

image

FraserGreenroyd commented 4 months ago

It's not possible right now, but it could be as part of our ongoing UX improvements this year in line with our settings engine and other changes we want to bring in to the search model to help people find the right component in the large library of components we now have. There may be an argument for adding SetGeometry(this Bar bar, Curve curve) to the Structure Engine which can call this IElement1D set geometry method to improve the UX as a stop-gap, but I know @IsakNaslundBh has had reservations against doing so in the past.