search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Facade_Engine: Updated AW methods to handle Cavity UValue #3316

Closed vgreen-BH closed 5 months ago

vgreen-BH commented 5 months ago

Issues addressed by this PR

Closes #3315

Updated UValueOpeningAW and UValueSpandrelAW methods so that the Cavity UValue fragment is only applied to the center of the opening and not to the edges.

Test files

New check has been added under section 5 of the SpandrelAWTestFile: https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/BHoM_Engine/Facade_Engine/BHoM%20PR%20Test%20Files?csf=1&web=1&e=pf2Sja

enarhi commented 5 months ago

@BHoMBot check required

bhombot-ci[bot] commented 5 months ago
@enarhi sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to do? For a list of available instructions, please see [this wiki page](https://github.com/BHoM/documentation/wiki/Continuous-Integration).
bhombot-ci[bot] commented 5 months ago
@enarhi to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 12 requests in the queue ahead of you.
FraserGreenroyd commented 5 months ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `copyright-compliance` - check `dataset-compliance` - check `ready-to-merge` There are 47 requests in the queue ahead of you.
FraserGreenroyd commented 5 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
FraserGreenroyd commented 5 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 72 requests in the queue ahead of you.
FraserGreenroyd commented 5 months ago

@vgreen-BH @enarhi just a gentle reminder to include change log labels and which engine is impacted most by your PR for future PRs - helps our automated systems for change logs 😄