search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 12 forks source link

Geometry_Engine: UTs refreshed and Boolean operations bugfixed #3319

Closed pawelbaran closed 4 months ago

pawelbaran commented 4 months ago

Issues addressed by this PR

Closes #3277 Closes #3318 Closes #3320

Test files

All tests serialised in this PR are scripted in GH and uploaded here

Changelog

Additional comments

UTs cover the following PRs from 7.1: https://github.com/BHoM/BHoM_Engine/pull/3275 https://github.com/BHoM/BHoM_Engine/pull/3280 https://github.com/BHoM/BHoM_Engine/pull/3283 https://github.com/BHoM/BHoM_Engine/pull/3290 https://github.com/BHoM/BHoM_Engine/pull/3292 https://github.com/BHoM/BHoM_Engine/pull/3293 https://github.com/BHoM/BHoM_Engine/pull/3298

pawelbaran commented 4 months ago

Thanks @peterjamesnugent - I tweaked the descriptions now as the bot checks have not been run yet 👍

pawelbaran commented 4 months ago

@BHoMBot check required

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 53 requests in the queue ahead of you.
FraserGreenroyd commented 4 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 4 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
pawelbaran commented 4 months ago

@BHoMBot check dataset-compliance @BHoMBot check copyright-compliance @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 4 months ago
@pawelbaran to confirm, the following actions are now queued: - check `dataset-compliance` - check `copyright-compliance` - check `ready-to-merge` There are 3 requests in the queue ahead of you.
FraserGreenroyd commented 4 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance

bhombot-ci[bot] commented 4 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.