search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 12 forks source link

Data_Engine: Fix typo in DomainTree creation #3321

Closed vietle-bh closed 4 months ago

vietle-bh commented 4 months ago

Issues addressed by this PR

Closes #3317

The existing code does (min + min)/2 which I've rectified to (min + max)/2.

Test files

It's just a typo so hopefully someone who worked on Domain Tree before can approve right away 😉

Changelog

Additional comments

vietle-bh commented 4 months ago

@BHoMBot check required

bhombot-ci[bot] commented 4 months ago
@vietle-bh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 20 requests in the queue ahead of you.
FraserGreenroyd commented 4 months ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check unit-tests @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 4 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `copyright-compliance` - check `dataset-compliance` - check `unit-tests` - check `ready-to-merge` There are 8 requests in the queue ahead of you.
FraserGreenroyd commented 4 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

bhombot-ci[bot] commented 4 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
FraserGreenroyd commented 4 months ago

@vietle-bh just a gentle reminder to include which engine is primarily affected by a PR to the BHoM_Engine repository in the title - I've added Data_Engine for this one 😄 just helps our automated change log processes