BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 12 forks source link

Facade_Engine: Geometry queries added for facade elements #3334

Closed pawelbaran closed 2 months ago

pawelbaran commented 2 months ago

Issues addressed by this PR

Closes #3333

Test files

See #3333

Changelog

Additional comments

pawelbaran commented 2 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 7 requests in the queue ahead of you.
pawelbaran commented 2 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 2 months ago

@BHoMBot check required

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 8 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 months ago
@pawelbaran just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit
bhombot-ci[bot] commented 2 months ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 months ago
@pawelbaran just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit
bhombot-ci[bot] commented 2 months ago
@pawelbaran just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit
pawelbaran commented 2 months ago

@BHoMBot check unit-tests @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests` - check `ready-to-merge`
pawelbaran commented 2 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests` There are 7 requests in the queue ahead of you.
pawelbaran commented 2 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 2 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 66 requests in the queue ahead of you.
pawelbaran commented 2 months ago

@BHoMBot check core @BHoMBot check serialisation @BHoMBot check null-handling @BHoMBot check versioning @BHoMBot check installer

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `core` - check `serialisation` - check `null-handling` - check `versioning` - check `installer` There are 91 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 months ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `24144886781`
IsakNaslundBh commented 2 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24144886781

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh I have now provided a passing check on reference `24144886781` as requested.
pawelbaran commented 2 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`