BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 12 forks source link

Matter_Engine: AggregateMaterialComposition is leaving hashes on materials #3335

Closed IsakNaslundBh closed 2 months ago

IsakNaslundBh commented 2 months ago

Description:

https://github.com/BHoM/BHoM_Engine/blob/57f9eb731191d3ed7ff07946b27148634601e449/Matter_Engine/Compute/AggregateMaterialComposition.cs#L104

is not functioning fully as intended, as the method is deep cloning the incoming object, and hence leaving the hash. Need to set the returned obejct to the list rather than just looping through the list.

Steps to reproduce:

Run method with any two material compositions.

Expected behaviour:

For no has to be present on the output materials in the material composition.

Test file(s):