search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 12 forks source link

Matter_Engine: Aggregate methods to ignore BHoM_Guid by default when comparing materials #3336

Closed IsakNaslundBh closed 2 months ago

IsakNaslundBh commented 2 months ago

Description:

The Base comparison config used to ignore the BHoM_Guid by default. This was however changed back in https://github.com/BHoM/BHoM/pull/1330 . Was unaware of the change then, but should make sure that this behaviour is reset, as currently a lot of duplicate materials are added to the compositions and takeoffs where only the Guid is the difference.

Steps to reproduce:

Run an Aggregate method for any takeoff/composition where there are any duplicate materials that are identical but created separately (giving them different BHoM_Guids.

Expected behaviour:

For BHoM_Guid to be ignored by default. A user could input a comparison config to change the behaviour. For this, also should include the config as input for the AggregateMaterialComposition method.

Test file(s):

IsakNaslundBh commented 2 months ago

Realising now that this is not actually an issue as the BHoM_Guid is always ignored:

https://github.com/BHoM/BHoM_Engine/blob/2f80210cef929c46fce11ae1f395322b5394d24d/BHoM_Engine/Query/Hash.cs#L254-L255

Issues I was finding here actually relates to #3335 and the Guid was just a ghost problem.

IsakNaslundBh commented 2 months ago

Closing due to comment above. Problem found was not related to BHoM_Guid but all steming from #3335