search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 12 forks source link

Matter_Engine: Make sure no hash fragments are stored in AggregateMaterialComposition #3337

Closed IsakNaslundBh closed 2 months ago

IsakNaslundBh commented 2 months ago

Issues addressed by this PR

Closes #3335

Change the way the AggregateMaterialComposition method works to align with the counterparts for the takeoffs.

Previous version led to revision fragments being stuck on the material, causing issues later on. It for example lead to continuous calls to other aggregation method to give different hashes.

Test files

here

Changelog

Additional comments

IsakNaslundBh commented 2 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 273 requests in the queue ahead of you.
IsakNaslundBh commented 2 months ago

@BHoMBot check required @BHoMBot check unit-tests

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` - check `unit-tests` There are 2 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 months ago
FAO: @FraserGreenroyd @IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `24202151496`
IsakNaslundBh commented 2 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24202151496

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh I have now provided a passing check on reference `24202151496` as requested.
IsakNaslundBh commented 2 months ago

Dispensating UTs as non of the failing ones are related to this PR

IsakNaslundBh commented 2 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge` There are 74 requests in the queue ahead of you.