search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 12 forks source link

Diffing_Engine: IsEqual method added #3338

Closed pawelbaran closed 2 months ago

pawelbaran commented 2 months ago

NOTE: Depends on

Issues addressed by this PR

Supports closing out https://github.com/BHoM/Test_Toolkit/issues/473

Test files

Very raw test file uploaded on SharePoint, also diffing test project written by @alelom

Changelog

Additional comments

pawelbaran commented 2 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 7 requests in the queue ahead of you.
pawelbaran commented 2 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests` There are 6 requests in the queue ahead of you.
pawelbaran commented 2 months ago

@alelom @IsakNaslundBh @FraserGreenroyd I ran the unit-tests check against develop under https://github.com/BHoM/BHoM_Engine/pull/3339 - the failures are exactly the same as on this branch, so I according to my best understanding, this PR together with https://github.com/BHoM/Test_Toolkit/pull/474 is neutral for the existing tests.

pawelbaran commented 2 months ago

@BHoMBot check compliance @BHoMBot check core

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `core`
pawelbaran commented 2 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `versioning`
pawelbaran commented 2 months ago

@BHoMBot check null-handling @BHoMBot check serialisation @BHoMBot check installer

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `null-handling` - check `serialisation` - check `installer` There are 49 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 months ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `24303460733`
FraserGreenroyd commented 2 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24303460733

bhombot-ci[bot] commented 2 months ago
@FraserGreenroyd I have now provided a passing check on reference `24303460733` as requested.
pawelbaran commented 2 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`