Closed pawelbaran closed 7 months ago
In different parts of reflection, some namespaces are considered valid BHoM or not:
ExtractAssembly
Regex
.Create.AllTypes
StartsWith
The above inconsistency introduces idiosyncrasies in some more complex reflection/serialisation workflows - would be great to unify across the entire code base.
Description:
In different parts of reflection, some namespaces are considered valid BHoM or not:
ExtractAssembly
is checking namespaces againstRegex
patterns: https://github.com/BHoM/BHoM_Engine/blob/7cb0fb17ea012daeace6cdc6b8b500693c8ffcf0/BHoM_Engine/Compute/ExtractAssembly.cs#L281-L282.Create.AllTypes
in BHoM_Engine: https://github.com/BHoM/BHoM_Engine/blob/7cb0fb17ea012daeace6cdc6b8b500693c8ffcf0/BHoM_Engine/Create/Type/AllTypes.cs#L50-L56StartsWith
queries: https://github.com/BHoM/BHoM_Engine/blob/7cb0fb17ea012daeace6cdc6b8b500693c8ffcf0/Serialiser_Engine/Compute/Serialise/Type.cs#L91 https://github.com/BHoM/BHoM_Engine/blob/7cb0fb17ea012daeace6cdc6b8b500693c8ffcf0/Serialiser_Engine/Compute/Deserialise/Type.cs#L148The above inconsistency introduces idiosyncrasies in some more complex reflection/serialisation workflows - would be great to unify across the entire code base.