BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 12 forks source link

BHoM_Engine & Serialiser_Engine: hardcoded namespace checks replaced with method calls #3341

Closed pawelbaran closed 2 months ago

pawelbaran commented 2 months ago

Issues addressed by this PR

Closes #3340

Test files

On SharePoint, passing the bot checks will also greatly add confidence.

Changelog

Additional comments

pawelbaran commented 2 months ago

@BHoMBot check compliance @BHoMBot check core

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `core` There are 12 requests in the queue ahead of you.
pawelbaran commented 2 months ago

@BHoMBot check serialisation

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `serialisation`
pawelbaran commented 2 months ago

@BHoMBot check null-handling @BHoMBot check versioning @BHoMBot check installer

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `null-handling` - check `versioning` - check `installer` There are 2 requests in the queue ahead of you.
pawelbaran commented 2 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `versioning` There are 39 requests in the queue ahead of you.
pawelbaran commented 2 months ago

@IsakNaslundBh following our offline chat, I have added quite solid UTs to the GH test script and serialised them into datasets - ready for (hopefully final) review! 💪

pawelbaran commented 2 months ago

@BHoMBot check versioning

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `versioning`
pawelbaran commented 2 months ago

@BHoMBot check core @BHoMBot check compliance @BHoMBot check serialisation @BHoMBot check null-handling

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `core` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `serialisation` - check `null-handling`
pawelbaran commented 2 months ago

@BHoMBot check required

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
IsakNaslundBh commented 2 months ago

@BHoMBot check dataset-compliance @BHoMBot check copyright-compliance @BHoMBot check unit-tests @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `dataset-compliance` - check `copyright-compliance` - check `unit-tests` - check `ready-to-merge`
bhombot-ci[bot] commented 2 months ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `24419999934`
IsakNaslundBh commented 2 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24419999934

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh I have now provided a passing check on reference `24419999934` as requested.
IsakNaslundBh commented 2 months ago

Granting dispensation on the basis that all new UTs are passing. Only failures found relates to UTs already failing