search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 12 forks source link

Spatial_Engine: Update failing UTs in Spatial engine #3346

Closed IsakNaslundBh closed 2 months ago

IsakNaslundBh commented 2 months ago

Issues addressed by this PR

Closes #3345

Both updated by simple regeneration.

FitPlane was not really failing. A completely flipped normal of the plane is still the same semantic plane, why a simple regeneration is acceptable.

The two failing cases for round coordinates were due to some of the resulting planes no longer being treated as planar. As the new method for IsPlanar is more exact, I think it is acceptable to regenerate these as well.

Test files

Changelog

Additional comments

IsakNaslundBh commented 2 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `unit-tests`
IsakNaslundBh commented 2 months ago

Not really sure why this is hanging. Runs on my machine, with passing results. @FraserGreenroyd are you able to see what is going on on the bot?

FraserGreenroyd commented 2 months ago

Not really sure why this is hanging. Runs on my machine, with passing results. @FraserGreenroyd are you able to see what is going on on the bot?

Had a look, couldn't see any issue. I recommend rerunning

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `unit-tests` There are 6 requests in the queue ahead of you.
IsakNaslundBh commented 2 months ago

@BHoMBot check compliance @BHoMBot check required

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 6 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 months ago
FAO: @FraserGreenroyd @IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `24768146530`
IsakNaslundBh commented 2 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24768146530

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh I have now provided a passing check on reference `24768146530` as requested.
IsakNaslundBh commented 2 months ago

Fixes 2 failing UTs. The flagged failures are not affected or intended to be affected.

IsakNaslundBh commented 2 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge`