Geometry_Engine: IsRigidTransformation bug fixed

BHoM / BHoM_Engine

Internal manipulation of the BHoM

GNU Lesser General Public License v3.0

26 stars 12 forks source link

Geometry_Engine: IsRigidTransformation bug fixed #3356

Open pawelbaran opened 1 month ago

pawelbaran commented 1 month ago

Issues addressed by this PR

Closes #3355

Test files

On SharePoint - also includes generation of UTs

Changelog

Additional comments

pawelbaran commented 1 month ago

@BHoMBot check required

bhombot-ci[bot] commented 1 month ago

@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`

pawelbaran commented 1 month ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 month ago

@pawelbaran to confirm, the following actions are now queued: - check `unit-tests` There are 27 requests in the queue ahead of you.

pawelbaran commented 1 month ago

Following the discussion with @IsakNaslundBh, we are parking this PR until the new milestone:

the fix in this PR is correct by itself
the methods consuming IsRigidTransformation are not ready for the change because a few Transform methods do not support reflection (e.g. the one against BH.oM.Structures.Elements.Bar would require mirroring the profile, similar to Beam and possible a few others)

To be picked up in 7.3 by tweaking individual Transform methods where needed.