Structure_Engine: Fixed bug where PanelToFEMesh returned an error

BHoM / BHoM_Engine

Internal manipulation of the BHoM

GNU Lesser General Public License v3.0

26 stars 12 forks source link

Structure_Engine: Fixed bug where PanelToFEMesh returned an error #3363

Open peterjamesnugent opened 2 weeks ago

peterjamesnugent commented 2 weeks ago

Issues addressed by this PR

Closes #3360 Closes #3365

Test files

PanelToFEMesh DiscontinuityPoints

Changelog

Fixed by bug whereby one Edge existed in the opposite direction to the Panel would caush an error for PanelToFEMesh;
Fixed bug whereby DiscontinuityPoints() did not work for PolyCurve;
Updated unit tests for DiscontinuityPoints() to include open PolyCurves;
Replaced unit tests for FEMeshToPanel and PanelToFEMesh as the data was empty.

Got the branch name wrong 🤐

peterjamesnugent commented 2 weeks ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 weeks ago

@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`

peterjamesnugent commented 2 weeks ago

Added @IsakNaslundBh's comments, I will leave the IsOutlineTriangular as it will likely be useful elsewhere.

peterjamesnugent commented 1 week ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 week ago

@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests` There are 6 requests in the queue ahead of you.

peterjamesnugent commented 5 days ago

@BHoMBot check required @BHoMBot check copyright-compliance

pawelbaran commented 5 days ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 5 days ago

@pawelbaran to confirm, the following actions are now queued: - check `copyright-compliance`

pawelbaran commented 5 days ago

@BHoMBot check required

bhombot-ci[bot] commented 5 days ago

@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`

peterjamesnugent commented 5 days ago

@BHoMBot check unit-tests @BHoMBot check dataset-compliance

bhombot-ci[bot] commented 5 days ago

@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests` - check `dataset-compliance`

pawelbaran commented 4 days ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 4 days ago

@pawelbaran to confirm, the following actions are now queued: - check `unit-tests` There are 41 requests in the queue ahead of you.

pawelbaran commented 1 day ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 day ago

@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`

pawelbaran commented 1 day ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 day ago

@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`

pawelbaran commented 1 day ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 day ago

@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`

peterjamesnugent commented 11 hours ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 11 hours ago

@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests`

peterjamesnugent commented 5 hours ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 5 hours ago

@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests`