BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Ground_Engine: Remove blankGeology from Stratum Create method #3375

Closed peterjamesnugent closed 2 months ago

peterjamesnugent commented 2 months ago

Issues addressed by this PR

Closes #3374

Test files

#12-HandlingBlankGeology.gh - this requires https://github.com/BHoM/AGS_Toolkit/pull/13 to be built #3374-VersionCheckForStratum this requires the Versioning_Toolkit to be built

Changelog

Additional comments

Do not merge until the AGS_Toolkit PR is ready

peterjamesnugent commented 2 months ago

@BHoMBot check required

bhombot-ci[bot] commented 2 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
pawelbaran commented 2 months ago

@BHoMBot check documentation-compliance

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `documentation-compliance`
peterjamesnugent commented 2 months ago

@BHoMBot check unit-tests @BHoMBot check dataset-compliance @BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 2 months ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `27334488723`
bhombot-ci[bot] commented 2 months ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `27334488723`
pawelbaran commented 2 months ago

Dispensating UTs on the basis of them being broken in the previous PRs.

pawelbaran commented 2 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27334488723

bhombot-ci[bot] commented 2 months ago
@pawelbaran I have now provided a passing check on reference `27334488723` as requested.
pawelbaran commented 2 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`
pawelbaran commented 2 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge` There are 13 requests in the queue ahead of you.