search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Search_Engine: Update unit tests for ExtractAll, ExtractTop, ExtractSorted and MatchScore #3377

Closed peterjamesnugent closed 1 month ago

peterjamesnugent commented 2 months ago

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1628

Issues addressed by this PR

Closes #3376

Test files

#3376-SearchEngineUTFailure

Changelog

Additional comments

One issue with unit tests was caused because it included a CustomObject that could not be serialised.

peterjamesnugent commented 2 months ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 2 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests` There are 18 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 months ago
@peterjamesnugent just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM
pawelbaran commented 2 months ago

@BHoMBot check required

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 31 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 months ago
@peterjamesnugent just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM
bhombot-ci[bot] commented 2 months ago
The check `versioning` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 months ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 months ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `27369815469`
bhombot-ci[bot] commented 2 months ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `27369815469`
bhombot-ci[bot] commented 2 months ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `27369815469`
pawelbaran commented 2 months ago

Dispensating unit test check on the basis of a fact that this PR lowers the number of failing UTs and does not introduce any new ones.

pawelbaran commented 2 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27369815469

bhombot-ci[bot] commented 2 months ago
@pawelbaran I have now provided a passing check on reference `27369815469` as requested.
pawelbaran commented 2 months ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `copyright-compliance` - check `dataset-compliance` - check `ready-to-merge`
pawelbaran commented 2 months ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `dataset-compliance`
pawelbaran commented 2 months ago

@BHoMBot check dataset-compliance

bhombot-ci[bot] commented 2 months ago
@pawelbaran to confirm, the following actions are now queued: - check `dataset-compliance`