BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Ground_Engine, BHoM_Engine: Add UnitTests for ConsolidateStrata, remove UTs for GeometryHash #3379

Closed peterjamesnugent closed 1 month ago

peterjamesnugent commented 1 month ago

Issues addressed by this PR

Closes #3378 Closes #3382

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/EfuNrrGbo51BoKd5CUBw1agBW86KkaYx17ZTBNp2-V3Beg?e=rMcf8E

Changelog

Additional comments

peterjamesnugent commented 1 month ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests`
peterjamesnugent commented 1 month ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 month ago
@peterjamesnugent to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 1 month ago

@BHoMBot check unit-tests

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `unit-tests`
pawelbaran commented 1 month ago

@BHoMBot check required

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
pawelbaran commented 1 month ago

Dispensating the unit-tests check based on the fact that the reported failure also occurs on develop.

bhombot-ci[bot] commented 1 month ago
FAO: @FraserGreenroyd @pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `27950483319`
pawelbaran commented 1 month ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27950483319

bhombot-ci[bot] commented 1 month ago
@pawelbaran I have now provided a passing check on reference `27950483319` as requested.
pawelbaran commented 1 month ago

@BHoMBot check dataset-compliance @BHoMBot check copyright-compliance

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 1 month ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`