Closed pawelbaran closed 3 months ago
@BHoMBot check compliance @BHoMBot check serialisation @BHoMBot check versioning
@BHoMBot check compliance @BHoMBot check serialisation @BHoMBot check versioning
@BHoMBot check versioning @BHoMBot check serialisation
@BHoMBot check installer @BHoMBot check core @BHoMBot check compliance @BHoMBot check unit-tests
@BHoMBot check null-handling
I am dispensating the failing UT check on the basis of the fact that all reported errors were present in the past (e.g. here). @peterjamesnugent @IsakNaslundBh maybe that's something we could try to clear/fix in the coming sprints?
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 28350420492
@BHoMBot check ready-to-merge
Issues addressed by this PR
Closes #3385 Closes #3386
Test files
Passing
serialisation
andversioning
checks should be enough of verification.Changelog
Additional comments
Fix for #3385 is almost self-explanatory, while #3386 requires a bit of explanation I believe. The origin of the bug is renaming of Revit assemblies that led me to finding out that
Create.EngineType
matches types based on fully qualified name - after renaming the assemblies the old and new names are different, resulting in a failure. Two steps were required to address that: