search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

Type matching based on unqualified names enabled in Create.EngineType #3389

Closed pawelbaran closed 1 month ago

pawelbaran commented 1 month ago

This is a reincarnation of https://github.com/BHoM/BHoM_Engine/pull/3387 required after renaming the branch

Issues addressed by this PR

Closes #3385 Closes #3386

Test files

Passing serialisation and versioning checks should be enough of verification.

Changelog

Additional comments

Fix for #3385 is almost self-explanatory, while #3386 requires a bit of explanation I believe. The origin of the bug is renaming of Revit assemblies that led me to finding out that Create.EngineType matches types based on fully qualified name - after renaming the assemblies the old and new names are different, resulting in a failure. Two steps were required to address that:

  1. Enabling matching by unqualified name
  2. Enabling picking first type in case of finding multiple matching types, similar to what we did with @IsakNaslundBh in https://github.com/BHoM/BHoM_Engine/pull/3344
pawelbaran commented 1 month ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 month ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`