BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 13 forks source link

BHoM_Engine: Additional check for assembly qualified type without version for Create EngineType #3399

Closed IsakNaslundBh closed 2 weeks ago

IsakNaslundBh commented 3 weeks ago

Issues addressed by this PR

Closes #3398

Add additional check for assembly qualified name without version. Important for edgecase of same namespace and typename, from different assemblies for types serialized in an older major version. Only runs this additional step if more than one type is found.

Generally having this duplication should most likely be avoided, but as that has not been enforced, and was not an issue before #3389 which fixed other critical issues, but introduced this edge case problem, we should still attempt to make sure it works after that fix.

Test files

All query components should deserialise correctly:

On Sharepointhttps://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BuroHappoldEngineering/ModelLaundry_Toolkit/[BuroHappold_BHoM_v3.3.beta_Structures_ML_BasicWorkFlow.gh](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BuroHappoldEngineering/ModelLaundry_Toolkit/BuroHappold_BHoM_v3.3.beta_Structures_ML_BasicWorkFlow.gh?csf=1&web=1&e=6E7xl3)?csf=1&web=1&e=6E7xl3

Changelog

Additional comments

IsakNaslundBh commented 3 weeks ago

@BHoMBot check compliance

bhombot-ci[bot] commented 3 weeks ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 1 requests in the queue ahead of you.
IsakNaslundBh commented 3 weeks ago

@BHoMBot check unit-tests @BHoMBot check required

bhombot-ci[bot] commented 3 weeks ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `unit-tests` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 1 requests in the queue ahead of you.
bhombot-ci[bot] commented 3 weeks ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 3 weeks ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 3 weeks ago

@BHoMBot check versioning

bhombot-ci[bot] commented 3 weeks ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `versioning`
IsakNaslundBh commented 2 weeks ago

@BHoMBot check compliance @BHoMBot check required @BHoMBot check unit-tests

bhombot-ci[bot] commented 2 weeks ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` - check `unit-tests`
bhombot-ci[bot] commented 2 weeks ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 weeks ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
pawelbaran commented 2 weeks ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 weeks ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`