search

BHoM / BHoM_Engine

Internal manipulation of the BHoM
GNU Lesser General Public License v3.0
26 stars 15 forks source link

Verification_Engine added #3431

Closed pawelbaran closed 1 week ago

pawelbaran commented 2 weeks ago

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1644

Issues addressed by this PR

Supports https://github.com/BHoM/BHoM/issues/1643

Test files

On SharePoint

Changelog

Additional comments

@alelom please note that the GH script mentioned under test files contains a suite of tests that fail to serialise due to a diffing bug - I will try to extract the exact culprit and raise an issue for you to debug. Once the bug gets fixed, I will gladly push UTs for this PR.

pawelbaran commented 2 weeks ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 weeks ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 5 requests in the queue ahead of you.
pawelbaran commented 2 weeks ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 weeks ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 2 weeks ago

@BHoMBot check core

bhombot-ci[bot] commented 2 weeks ago
@pawelbaran to confirm, the following actions are now queued: - check `core`
pawelbaran commented 2 weeks ago

@BHoMBot check installer

bhombot-ci[bot] commented 2 weeks ago
@pawelbaran to confirm, the following actions are now queued: - check `installer`
michal-pekacki commented 2 weeks ago

If we compare two strings with LessThan and GreaterThan comparison type the result for both is False and we have following entry in the report: image

Shouldn't we disable numeric comparisons for strings?

pawelbaran commented 2 weeks ago

Thanks @michal-pekacki, I've just fixed that, returning null as inconclusive in such cases 👍

michal-pekacki commented 2 weeks ago

Shouldn't we be consistent and do the same when comparing number to string? In following entry comparing numeric ValueSource with string ReferenceValue doesn't return null:

image

pawelbaran commented 2 weeks ago

Ha, I disabled comparing numbers to strings now, thanks for another good catch @michal-pekacki 👍 also added test cases

pawelbaran commented 1 week ago

@BHoMBot check required

bhombot-ci[bot] commented 1 week ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 4 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 week ago
@pawelbaran just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM
bhombot-ci[bot] commented 1 week ago
The check `versioning` has already been run previously and recorded as a successful check. This check has not been run again at this time.
pawelbaran commented 1 week ago

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance @BHoMBot check unit-tests

bhombot-ci[bot] commented 1 week ago
@pawelbaran to confirm, the following actions are now queued: - check `copyright-compliance` - check `dataset-compliance` - check `unit-tests`
pawelbaran commented 1 week ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 week ago
@pawelbaran to confirm, the following actions are now queued: - check `ready-to-merge`