search

BHoM / BHoM_Installer

0 stars 2 forks source link

Stop copying all DLLs to Dynamo/2.3/packages/BHoM/bin #105

Closed FraserGreenroyd closed 3 years ago

FraserGreenroyd commented 3 years ago

Fixes #104

This will still copy DLLs to Dynamo to 2.0/packages/BHoM/bin This will still install the pkg.json to 2.3/packages/BHoM This will no longer copy all BHoM DLLs to 2.3/packages/BHoM/bin - see comments below.

The bin folder for 2.3/packages/BHoM is the bit I've taken out because I think that was the issue (but I'm very tired at the moment, so the odds of me misinterpreting the situation are high!

adecler commented 3 years ago

The bin folder for 2.3/packages/BHoM is the bit I've taken out because I think that was the issue (but I'm very tired at the moment, so the odds of me misinterpreting the situation are high!

That's probably linked to my lack of details as well. The bin folder should still exist but not with all the dlls in it as it is for the moment.

When I compile the dynamo toolkit locally after having deleted the BHoM folder in Roaming, this is what I get:

image

When I run the installer, this is what I get:

image

FraserGreenroyd commented 3 years ago

Am about to send a new artefact to @adecler and @pawelbaran for testing.

Running it myself I now get this in the 2.3 bin folder:

image

So hopefully maybe possibly this one will work?

FraserGreenroyd commented 3 years ago

/azp run BHoM.BHoM_Installer

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 1 pipeline(s).
adecler commented 3 years ago

This installer is causing Dynamo 2.3 (in Revit 2020) to freeze when I try to create a component from the side menu (I tried CreateCustom).

Here's the procedure I followed:

This is annoying because I cannot debug this without recompiling it locally so not sure what to do next.

Might be worth for you both to try (and maybe a few others) to see if you get the same problem

pawelbaran commented 3 years ago

@adecler by freezing you mean that the UI still seems to respond but simply nothing happens when you hit any button? That is what happens when I try dropping CreateCustom from side menu on Revit2020 + 2.3. However, everything is fine if I start from creating a native Dynamo component before I do any BHoM - I think we had that issue before...

adecler commented 3 years ago

By freezing I mean unresponsive. You're not able to do anything bot close Dynamo. Only happening with that installer. The master branch is fine.

I didn't try to create a Dynamo component first but that solves the problem, it might be don't to incompatible dlls again.

FraserGreenroyd commented 3 years ago

So following discussion, this risks introducing breaking problems which need investigating fully before we merge this, so sticking a parked label for now. @pawelbaran to run some more tests to help try and identify the problem and report back ASAP.

pawelbaran commented 3 years ago

I have tried 3 different scenarios, each of them twice:

  1. Installer from this branch:
    • when the BHoM component gets dropped on the canvas first, the UI gets broken (you can still navigate through the side panel, but the clicks do not respond, nothing can be done in the canvas, top navigation bar does not work etc.)
    • when one starts from creating a native Dynamo component, everything is fine
    • the above 2 bullet points are the exact issue we had before
  2. Daily build:
    • same behaviour as above
  3. Compiled from master:
    • all works fine

So looks like both installers break Dynamo, while building from source does not 🤯

FraserGreenroyd commented 3 years ago

So the difference with the daily build there seems different to what @adecler was describing? If it is happening with the daily alpha as well then that suggests there is another avenue to explore but might not be related to this PR, but @adecler suggested the daily alpha was working on for him? @adecler thoughts?

adecler commented 3 years ago

The daily alpha from a few days ago was working for me. Given that last time as an issue with some incompatible dlls, it might just be that some recent work unrelated to Dynamo broke it again. That's going to be pretty difficult if compiling locally fixes the problem though.

I will try to have a look at some point but got derailed by other bug fixing request this morning so need to catch up with my backlog first.

adecler commented 3 years ago

@FraserGreenroyd , I confirm that the bug also happens on the daily alpha. So my assumption would be that a recent PR on another repo caused the bug, not this change on the installer.

For reference, here's the discussion around the same problem we had a while ago: https://github.com/BHoM/Dynamo_Toolkit/issues/232 This time, the fact that everything works fine when compiling Dynamo manually makes it a bit harder to debug. But, if anything this PR makes thing simpler by avoiding duplicate dlls in Roaming Dynamo BHoM and ProgramData.

FraserGreenroyd commented 3 years ago

Thumbs up received from @pawelbaran so merging now, thanks both! :smile: