search

BHoM / BHoM_Installer

0 stars 2 forks source link

Make sure that the sources Python files are copied #82

Closed epignatelli closed 4 years ago

epignatelli commented 4 years ago

NOTE: Depends on

Issues addressed by this PR

Closes #81 Closes https://github.com/BHoM/MachineLearning_Toolkit/issues/42 Closes https://github.com/BHoM/Python_Toolkit/issues/36

The Python_Toolkit and the MachineLearning_Toolkit, at compile time, copy the *.py files over to C:\ProgramData\BHoM\python-3.7.3-embed-amd64\src but the installer does not handle it.

This pr takes care of that.

Test files

DOD: after installing the BHoM you should see a folder C:\ProgramData\BHoM\python-3.7.3-embed-amd64\src with subfolders Python_Toolkit and MachineLearning_Toolkit.

Changelog

Additional comments

epignatelli commented 4 years ago

Thanks for the thorough chekc @FraserGreenroyd !

Adding also @al-fisher to reviewers!

al-fisher commented 4 years ago

Thanks both - will review and comment

epignatelli commented 4 years ago

Yes! That seems sensible.

I will change the directories in this repo using this pr, but it also require a change in the Python_Toolkit. Will raise another pr there.

FraserGreenroyd commented 4 years ago

@epignatelli let's go for a couple of dependant PRs and do them all at once, I'm happy to review changes to Python/Machine Learning to make this happen and merge them all together :smile:

al-fisher commented 4 years ago

Thanks @epignatelli @FraserGreenroyd

To capture agreement earlier Folder structure to be : Extensions\Python\

epignatelli commented 4 years ago

@FraserGreenroyd got any idea why the installer is failing?

Oh sorry - here you go File not found - src https://dev.azure.com/BHoMBot/BHoM/_build/results?buildId=12856&view=logs&j=6b902995-b73d-5f5c-66fd-a7f66c857d2c&t=fa8205cc-5849-5ef9-c89d-bc580008b365&l=432

Might it be that the installer is not picking up the right Python_Toolkit branch?

FraserGreenroyd commented 4 years ago

@epignatelli yeah the installer tends not to link branches as we prefer to isolate it for checks. I'll do a review of python and machine learning ASAP and then we can rerun here

epignatelli commented 4 years ago

/azp run BHoM.BHoM_Installer

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 1 pipeline(s).
epignatelli commented 4 years ago

@FraserGreenroyd I have just re-done the check with the new master branches. Would you mind giving this another review after these changes?

@al-fisher this now aligns with the new Extensions\ folder, and python will be in Extensions\Python\

FraserGreenroyd commented 4 years ago

/azp run BHoM.BHoM_Installer

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 1 pipeline(s).
epignatelli commented 4 years ago

Thanks @al-fisher !

@FraserGreenroyd can we merge if your're happy?

FraserGreenroyd commented 4 years ago

Sorry @epignatelli I didn't see the dismissal from @al-fisher ! Merging now :smile: