search

BHoM / BHoM_Installer

0 stars 2 forks source link

Update folders to delete on install #87

Closed FraserGreenroyd closed 4 years ago

FraserGreenroyd commented 4 years ago

Issues addressed by this PR

Fixes #77

Test files

Changelog

Additional comments

FraserGreenroyd commented 4 years ago

image

I would argue it is in scope of this PR based on the above from the issue - I will take a look and report back

FraserGreenroyd commented 4 years ago

Having said that, I cannot see in the code where the Extensions folder would be removed.

image

This is the code handling it, and it's set specifically for the folders named - was this repeatable as an issue over a couple of uninstalls @al-fisher ?

al-fisher commented 4 years ago

Will re-test a couple of times now

al-fisher commented 4 years ago

Yes - can confirm - very repeatable. Left with just \Logs and \Settings after remove. Do you get the same?

FraserGreenroyd commented 4 years ago

image

This is my folder structure following an uninstall, however the contents have been cleared but the folder structure all stays in place, but that's on a first attempt. Doing a second attempt now...

FraserGreenroyd commented 4 years ago

Second attempt has resulted in the same, intact folder structure but all empty of files.

Maybe given the timeline we're working to, and the extensions folder returning after reinstall this could be put into a new issue for further investigation owing to the other bits depending on this for the Analytics?

al-fisher commented 4 years ago

Yes - strange behaviour. But I am minded to log as separate issue as not critical (is mirroring at least the same, or better than, current installer behaviour)

FraserGreenroyd commented 4 years ago

In that case I think we're in agreement and can go for approval and merge with a new issue :smile:

FraserGreenroyd commented 4 years ago

@al-fisher issue #88 raised - going for merge now :smile: