search

BHoM / BHoM_UI

GNU Lesser General Public License v3.0
9 stars 5 forks source link

Duplicated input in a ModelLaundry test file component #303

Closed LMarkowski closed 4 years ago

LMarkowski commented 4 years ago

Description:

While testing environment workflow in ModelLaundry I found a failing component with that error: image It looks like the first input is duplicated. After placing that same component and plugging extracted inputs everything seems to work fine. image Duplicated Locations are almost identical, but they have different BHoM_Guids.

Steps to reproduce:

Edit: Moved failing component to a seperate file here to clean the Environment ML Workflow test file. Open BuroHappold_BHoM_v3.3.beta_Environment_ML_BasicWorkFlow.gh file from here /Edit

@adecler (as it is UI) @FraserGreenroyd (as it is environment) @al-fisher (as it happened while testing for foundational)

adecler commented 4 years ago

Note: for those wanting test this, the file to download is BuroHappold_BHoM_v3.3.beta_Environment_ML_BasicWorkflow.gh, not BuroHappold_BHoM_v3.3.beta_Structures_ML_BasicWorkFlow.gh

LMarkowski commented 4 years ago

@adecler You're right. I must've copied wrong line, sorry. Updated the description.

adecler commented 4 years ago

This component was already in an invalid state when saved in the file:

image

As you can see the Grasshopper itself already has two Location input params even before trying to update itself from the BHoM info.

The input parameters saved in the json are

So the double Location input should fix itself (so, there is a bug there). Note that Name input will likely be double once the bug is fixed though since the saved sate of the component was already incorrect.