search

BHoM / BHoM_UI

GNU Lesser General Public License v3.0
9 stars 6 forks source link

Fix Property access type for specific case of accessing Object.List.Property #376

Closed adecler closed 3 years ago

adecler commented 3 years ago

Issues addressed by this PR

Closes #375

Fix the case where the user try to set a property of object inside a list property. Example: setting the property Layers.Material of a Construction.

This also added a fallback object type for case where the user is trying to set properties in the CustomData for example.

Test files

Use the one provided in the issue.

I have also added some additional check where the List property is not following an interface property just to be sure (as those two scenarios are treated slightly differently).

I would recommend also testing anything that comes to mind or existing files as it seems there are still cases I don't think about (as this PR proves). I have, for example, re-tested the file from this PR: https://github.com/BHoM/BHoM_UI/pull/371

adecler commented 3 years ago

@BHoMBot check copyright

bhombot-ci[bot] commented 3 years ago
@adecler to confirm, `check-copyright-compliance` task is now queued.
adecler commented 3 years ago

@BHoMBot check installer

bhombot-ci[bot] commented 3 years ago
@adecler sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to run? For example, if you would like me to run the `check-core` comment: _"@BHoMBot check core"_
bhombot-ci[bot] commented 3 years ago
@adecler to confirm, `check-installer` task is now queued.