search

BHoM / BHoM_UI

GNU Lesser General Public License v3.0
9 stars 5 forks source link

Migrate ISettings to the oM.Base namespace #394

Closed adecler closed 3 years ago

adecler commented 3 years ago

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1249

Issues addressed by this PR

Closes #393

To add a bit of context: Adapters like the BuildingPerformance adapter will need to depend on ISettings to store the link to the database. So it is important that we don't add dependencies between adapter toolklits and the BHoM_UI repo (even if ISettings is in oM.UI, this is still a repo-level dependency we would like to avoid)

Test files

Just make sure everything still compiles and that an installer can be created.

adecler commented 3 years ago

@BHoMBot check required

bhombot-ci[bot] commented 3 years ago
@adecler to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `core` - `null-handling` - `serialisation` - `installer` - `versioning`
FraserGreenroyd commented 3 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 3 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance` There are 11 requests in the queue ahead of you.