search

BHoM / BHoM_UI

GNU Lesser General Public License v3.0
9 stars 5 forks source link

Code alignment to the changes done in BHoM_Engine #2649 #406

Closed pawelbaran closed 2 years ago

pawelbaran commented 2 years ago

NOTE: Depends on

https://github.com/BHoM/BHoM_Engine/pull/2649

Issues addressed by this PR

Closes #

Test files

See https://github.com/BHoM/BHoM_Engine/pull/2649 - as for this PR, if it compiles, all is fine.

Changelog

Additional comments

pawelbaran commented 2 years ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 years ago
@pawelbaran to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance` There are 2 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
@pawelbaran just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 2 years ago
@pawelbaran just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
pawelbaran commented 2 years ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 years ago
@pawelbaran to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance`
pawelbaran commented 2 years ago

@BHoMBot check null-handling @BHoMBot check core @BHoMBot check installer @BHoMBot check serialisation @BHoMBot check versioning

bhombot-ci[bot] commented 2 years ago
@pawelbaran to confirm, the following checks are now queued: - `null-handling` - `core` - `installer` - `serialisation` - `versioning` There are 8 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
@pawelbaran just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 2 years ago
@pawelbaran just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 2 years ago
@pawelbaran just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 2 years ago
@pawelbaran just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 2 years ago
@pawelbaran just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 2 years ago
@pawelbaran just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 2 years ago
@pawelbaran just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
bhombot-ci[bot] commented 2 years ago
@pawelbaran just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine
pawelbaran commented 2 years ago

Replaced with #407