Closed FraserGreenroyd closed 1 year ago
@BHoMBot check compliance
@BHoMBot check compliance
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 16280314097
@BHoMBot check versioning
@BHoMBot check core
@BHoMBot check versioning
@BHoMBot check installer @BHoMBot check copyright-compliance @BHoMBot check project-compliance
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 16281528423
To summarise the discussion I just had with @FraserGreenroyd , I feel that this PR doesn't address the underlying problem of the deserialisation of lists of lists that comes from an external serialisation source. So this PR runs the risk of masking the problem instead of fixing it.
See below the resulting serialisation of a List of lists fully created within the BHoM vs the one coming coming from a deserialisation of external json:
As you can see, the later generates 'messier' json independently of the Explode issue addressed here. If that deserialisation is resolved, the Explode issue should go away.
We might still need to improve the Explode component if we find other cases of List<T>
represented as List<object>
or even lists of objects that contain multiple types (including List<T>
) but then the PR should be done addressing the problem in its larger context, not just this one caused by serialisation.
Closing this in favour of this PR - we can reopen this if needed
Fixes https://github.com/BHoM/BHoM_Engine/issues/2674
Test Files
Available here. The JSON used has come from @tg359 on the linked issue which this PR aims to resolve.
On alpha:
On this PR:
If testing using the provided test script please make sure you redrag the output of
FromJson
into theExplode
component to get it to update. Alternatively, drop a newExplode
component on the canvas and compare the cached one with the one from this PR.E.G: