BHoM / BHoM_UI

GNU Lesser General Public License v3.0
9 stars 5 forks source link

Add ability to load settings #484

Closed FraserGreenroyd closed 6 months ago

FraserGreenroyd commented 6 months ago

NOTE: Depends on

https://github.com/BHoM/BHoM_Engine/pull/3300 https://github.com/BHoM/BHoM_Engine/pull/3302 https://github.com/BHoM/BHoM_Engine/pull/3304

Issues addressed by this PR

Fixes #483

Test files

Same as #482

Use this JSON file to load in and see what changes you get: BH.oM.UI.SearchSettings.json

Try to break the JSON file and check you get errors as well.

You should find the first few alphabetical options are unchecked, and you should get a new addition of ABCDEF being checked - it will likely render at the bottom first but on a reload of the settings window you'll find it at the top.

Changelog

Additional comments

I have removed the Reset button because this was effectively duplicating the Select/Unselect all buttons, and it was only resetting to check everything rather than resetting to the originally loaded state or similar. Thus, with discussion with @Tom-Kingstone and @albinber this looked like it could cause a negative UX, so has been removed to avoid confusion.

Tooltips have been added to aid usability though.

FraserGreenroyd commented 6 months ago

@BHoMBot check project-compliance @BHoMBot check copyright-compliance

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `project-compliance` - check `copyright-compliance`
FraserGreenroyd commented 6 months ago

@BHoMBot check project-compliance @BHoMBot check copyright-compliance

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `project-compliance` - check `copyright-compliance`
FraserGreenroyd commented 6 months ago

@BHoMBot check versioning @BHoMBot check installer @BHoMBot check core

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning` - check `installer` - check `core`
FraserGreenroyd commented 6 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge`