Closed FraserGreenroyd closed 6 months ago
@BHoMBot check project-compliance @BHoMBot check copyright-compliance
@BHoMBot check project-compliance @BHoMBot check copyright-compliance
@BHoMBot check versioning @BHoMBot check installer @BHoMBot check core
@BHoMBot check ready-to-merge
NOTE: Depends on
https://github.com/BHoM/BHoM_Engine/pull/3300 https://github.com/BHoM/BHoM_Engine/pull/3302 https://github.com/BHoM/BHoM_Engine/pull/3304
Issues addressed by this PR
Fixes #483
Test files
Same as #482
Use this JSON file to load in and see what changes you get: BH.oM.UI.SearchSettings.json
Try to break the JSON file and check you get errors as well.
You should find the first few alphabetical options are unchecked, and you should get a new addition of
ABCDEF
being checked - it will likely render at the bottom first but on a reload of the settings window you'll find it at the top.Changelog
Additional comments
I have removed the
Reset
button because this was effectively duplicating theSelect/Unselect all
buttons, and it was only resetting to check everything rather than resetting to the originally loaded state or similar. Thus, with discussion with @Tom-Kingstone and @albinber this looked like it could cause a negative UX, so has been removed to avoid confusion.Tooltips have been added to aid usability though.