BHoM / Dynamo_UI

Tools for Dynamo
GNU Lesser General Public License v3.0
8 stars 6 forks source link

UI Refactoring #255

Closed adecler closed 4 years ago

adecler commented 4 years ago

NOTE: Depends on

https://github.com/BHoM/BHoM_UI/pull/297

Issues addressed by this PR

See https://github.com/BHoM/BHoM_UI/pull/297 for details

Right now, only minor changes to keep things working have been done. Sprint 3 will focus on leveraging the changes on BHoM_UI.

Fixes #256

Test files

Changelog

Additional comments

IsakNaslundBh commented 4 years ago

Did some first really quick testing. Some issues found.

Dynamo 1.3

Tried simply pulling some bars from Robot, exploding them and exploding the start node. Pulling worked, exploding the bars worked, exploding the start nodes did not work. Component complained about outputs not matching outputs straight after plugged in:

image

Dynamo 2.0

Tried setting up the same script in dynamo for revit 2020 (version 2.X)

I did start by adding a random native component to the canvas before doing any BHoMRelated things.

  1. Ctrl+shift+b menu does not work (think this was here before as well)
  2. Tried creating the same script as I did for 3.0. Dynamo crashed out when trying to select structural Bar from the CreateType component
pawelbaran commented 4 years ago

Today we made a functionality review together with @adecler, in general everything works fine, 2 major bugs found:

All tests were run on Dynamo 2.X because as discussed in https://github.com/BHoM/Dynamo_Toolkit/issues/249, 1.3 is meant not to be supported any more.

adecler commented 4 years ago

@pawelbaran , both bugs are now fixed (one was fixed in BHoM_UI). Can you confirm you are happy with the changes ?

pawelbaran commented 4 years ago

Everything seems to work fine, happy! 👍

pawelbaran commented 4 years ago

/azp run Dynamo_Toolkit.CheckInstaller

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 1 pipeline(s).