search

BHoM / Dynamo_UI

Tools for Dynamo
GNU Lesser General Public License v3.0
8 stars 5 forks source link

Log file id and file path #293

Closed adecler closed 3 years ago

adecler commented 3 years ago

NOTE: Depends on

https://github.com/BHoM/BHoM_Engine/pull/2312 https://github.com/BHoM/BHoM_UI/pull/370

Issues addressed by this PR

Provide changes required for fileName and project code to be saved by analytics.

Test files

Will be tested alongside the BHoMAnalytics PR

adecler commented 3 years ago

@BHoMBot check copyright

bhombot-ci[bot] commented 3 years ago
@adecler to confirm, `check-copyright-compliance` task is now queued.
bhombot-ci[bot] commented 3 years ago
@adecler just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_UI
AndreBalasian commented 3 years ago

Is it possible to log usage by Dynamo scripts that don't contain any BHoM functionality, perhaps by calling some method? If so, could you recommend a method that doesn't do much, but could be placed in a script for the sake of logging the use of that script file?

adecler commented 3 years ago

Is it possible to log usage by Dynamo scripts that don't contain any BHoM functionality, perhaps by calling some method? If so, could you recommend a method that doesn't do much, but could be placed in a script for the sake of logging the use of that script file?

@AndreBalasian , The new SetProjectID component from this set of PRs seems to be a good candidate for that. See https://github.com/BHoM/BHoM_UI/pull/370

bhombot-ci[bot] commented 3 years ago
@adecler just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_UI
pawelbaran commented 3 years ago

I have just tested the PR, looks like it works fine locally (SetProjectID checked, local log creation checked, local log update checked). Could you check if the logs got recorded in the database too, @adecler @al-fisher? ProjectIds are Hey Jude 18 for Revit 2018 + Dynamo 2.0 and Hey Jude 20 for Revit 2020 and Dynamo 2.3 🙈

adecler commented 3 years ago

Could you check if the logs got recorded in the database too, @adecler @al-fisher? ProjectIds are Hey Jude 18 for Revit 2018 + Dynamo 2.0 and Hey Jude 20 for Revit 2020 and Dynamo 2.3 🙈

Yes, they are showing in the database. Thanks @pawelbaran