Closed GCRA101 closed 3 days ago
I have tested the functionality and happy that it works as expected with the test scripts provided. @GCRA101 I will wait until the comments above have been addressed before approving this PR.
@IsakNaslundBh , @Chrisshort92 , thank you for reviewing and for your comments. I've updated the inheritance of the SpandrelForce Class to be from BarResult rather than from BarForce.
Updated code pushed to origin for your final check.
@peterjamesnugent thanks for your comments. I've updated the code in line with them. Retested using the linked etabs model file and the gh script. All works fine.
@BHoMBot check required
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge
@peterjamesnugent , @Chrisshort92
I've updated the initialization call of the PierAndSpandrel enum as suggested by Isak in today's call. You can find the updated code for your review in the latest commit. c01050f91e6fb78b7f248fef8b6158614154ee70
@BHoMBot check required
@BHoMBot check copyright-compliance
@BHoMBot check null-handling
@BHoMBot check ready-to-merge
Issues addressed by this PR
Closes #430
Test files
Grasshopper File https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23457-AddSpandrelForceResult/Test%20Script.gh?csf=1&web=1&e=caphlX ETABS File https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23457-AddSpandrelForceResult/Test%20ETABS%20Model.EDB?csf=1&web=1&e=6N8BDm
Changelog