BHoM / ETABS_Toolkit

Tools for ETABS and CSI Software
GNU Lesser General Public License v3.0
19 stars 9 forks source link

Add Spandrel Force Result #457

Closed GCRA101 closed 3 days ago

GCRA101 commented 2 months ago

Issues addressed by this PR

Closes #430

Test files

Grasshopper File https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23457-AddSpandrelForceResult/Test%20Script.gh?csf=1&web=1&e=caphlX ETABS File https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23457-AddSpandrelForceResult/Test%20ETABS%20Model.EDB?csf=1&web=1&e=6N8BDm

TestScreenshot

Changelog

Chrisshort92 commented 2 months ago

I have tested the functionality and happy that it works as expected with the test scripts provided. @GCRA101 I will wait until the comments above have been addressed before approving this PR.

GCRA101 commented 2 months ago

@IsakNaslundBh , @Chrisshort92 , thank you for reviewing and for your comments. I've updated the inheritance of the SpandrelForce Class to be from BarResult rather than from BarForce.

Updated code pushed to origin for your final check.

SpandrelForceClassInheritance

GCRA101 commented 2 months ago

@peterjamesnugent thanks for your comments. I've updated the code in line with them. Retested using the linked etabs model file and the gh script. All works fine.

Chrisshort92 commented 2 months ago

@BHoMBot check required

bhombot-ci[bot] commented 2 months ago
@Chrisshort92 to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
GCRA101 commented 2 months ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 months ago
@GCRA101 to confirm, the following actions are now queued: - check `copyright-compliance`
GCRA101 commented 2 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 months ago
@GCRA101 to confirm, the following actions are now queued: - check `ready-to-merge`
GCRA101 commented 1 month ago

@peterjamesnugent , @Chrisshort92

I've updated the initialization call of the PierAndSpandrel enum as suggested by Isak in today's call. You can find the updated code for your review in the latest commit. c01050f91e6fb78b7f248fef8b6158614154ee70

peterjamesnugent commented 1 week ago

@BHoMBot check required

bhombot-ci[bot] commented 1 week ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
GCRA101 commented 6 days ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 6 days ago
@GCRA101 to confirm, the following actions are now queued: - check `copyright-compliance`
GCRA101 commented 6 days ago

@BHoMBot check null-handling

bhombot-ci[bot] commented 6 days ago
@GCRA101 to confirm, the following actions are now queued: - check `null-handling`
GCRA101 commented 6 days ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 6 days ago
@GCRA101 to confirm, the following actions are now queued: - check `ready-to-merge`