Internalise Data not working in some cases

rwemay commented 5 years ago

As above.

~~Create a BHoM object, right click whilst in page break view, and note that the internalise data is not visible in the context menu.~~
When data is internalised (in normal view) the hidden sheet is created, however, the cell with the internalised data retains the formula/original entry, such that there is no reference to the internalised data.

~~Internalise data should always be visible in context menu when BHoM is loaded/initialised.~~
When data is internalised, the cell contents should be replaced such that upstream/referenced changes in the spreadsheet do not cause the cell with internalised data to lose reference.

awakeman commented 4 years ago

Reopening this issue for the time being whilst I investigate the second issue. see discussion in #153

Scheduling for next milestone.

Will close again if the issue originates in another toolkit.

awakeman commented 4 years ago

Worth re-testing this given recent changes in Serialiser_Engine.

kayleighhoude commented 4 years ago

This is a continuous issue on my end (building off of alphas since the 3.1 milestone)

adecler commented 4 years ago

This should be fixed by the UI refactoring PR on Excel (https://github.com/BHoM/Excel_Toolkit/pull/243) as I use a completely different system that doesn't retain the original formula.

BHoM / Excel_UI