search

BHoM / Excel_UI

GNU Lesser General Public License v3.0
5 stars 4 forks source link

New features for the Building Performance Form #305

Closed adecler closed 3 years ago

adecler commented 3 years ago

Issues addressed by this PR

Closes #302 Closes #303 Closes #304

All the features are implemented to support required functionalities for the Building Performance Excel form.

Test files

https://burohappold.sharepoint.com/:x:/r/sites/Direction/designtechnology/RandDWishlist/00229_BuildingPerformance_DataEntryTemplate/BuildingPerformanceForm2.xlsm?d=waa06976ed94c4ce2823c19904a293234&csf=1&web=1&e=wHEK3T

Changelog

Additional comments

adecler commented 3 years ago

@BHoMBot check required

bhombot-ci[bot] commented 3 years ago
@adecler to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `core` - `null-handling` - `serialisation` - `installer` - `versioning`
adecler commented 3 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 3 years ago
@adecler to confirm, the following checks are now queued: - `copyright-compliance` There are 9 requests in the queue ahead of you.
bhombot-ci[bot] commented 3 years ago
FAO: @FraserGreenroyd @adecler is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is project-compliance. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. `3044587898`
adecler commented 3 years ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 3 years ago
@adecler to confirm, the following checks are now queued: - `project-compliance`
adecler commented 3 years ago

@FraserGreenroyd , I have changed the copy local to false (as discussed before, I don't see those as necessary anymore but fine). Can you check that you are happy ?

adecler commented 3 years ago

@BHoMBot check required

bhombot-ci[bot] commented 3 years ago
@adecler to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `core` - `null-handling` - `serialisation` - `installer` - `versioning`
adecler commented 3 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 3 years ago
@adecler to confirm, the following checks are now queued: - `copyright-compliance` There are 9 requests in the queue ahead of you.
bhombot-ci[bot] commented 3 years ago
FAO: @FraserGreenroyd @adecler is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is project-compliance. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. `3045505323`
adecler commented 3 years ago

@tg359 , I have made the change requested by Fraser. All same functionality as before, just a referenced dll not being copied locally to the build folder anymore (archaic concern that is now irrelevant). Can you re-approve please ?