search

BHoM / Excel_UI

GNU Lesser General Public License v3.0
5 stars 4 forks source link

Align with changes in oM and Engine on Reflection -> Base #327

Closed FraserGreenroyd closed 2 years ago

FraserGreenroyd commented 2 years ago

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1339 https://github.com/BHoM/BHoM_Engine/pull/2729 https://github.com/BHoM/BHoM_Adapter/pull/318

Issues addressed by this PR

Test files

Changelog

Additional comments

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM
FraserGreenroyd commented 2 years ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `project-compliance` There are 14 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `4788372167`
FraserGreenroyd commented 2 years ago

@BHoMBot fix project file ref. 4788372167

bhombot-ci[bot] commented 2 years ago
@frasergreenroyd I am now going to fix the CSProject compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 2 years ago
@frasergreenroyd to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request.
FraserGreenroyd commented 2 years ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `project-compliance` There are 3 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoMAnalytics_Toolkit
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM
adecler commented 2 years ago

Actually... The BHoM tab was not showing in the ribbon (the global menu and all other BHoM formula were working fine).

The issue was that the SetProperty component now had an empty description and it seems the respond from Excel to that is to ignore the entire ribbon 😲 . So I'll add a fix here to only add a supertip if the description is not empty since this seems like quite a big issue.

As for why the description was empty, the BHoM_UI Component is actually still pointing to the SetPropertyValue in the Reflection Engine so I'll fix that in the BHoM_UI PR. I tested all the other components once I got to testing Grasshopper and they are all working fine except for the SetProperty one

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine
FraserGreenroyd commented 2 years ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, copyright-compliance, dataset-compliance, documentation-compliance, null-handling, project-compliance, ready-to-merge, serialisation

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.