Assign ID to faces when pulling

BHoM / GSA_Toolkit

GSA tools and methods for use in other applications and repositories

GNU Lesser General Public License v3.0

5 stars 2 forks source link

Assign ID to faces when pulling #239

Closed IsakNaslundBh closed 3 years ago

IsakNaslundBh commented 3 years ago

Issues addressed by this PR

Closes #238

Load push was changed to look at ids of faces rather than the mesh. This change should have been made simultaneously, as without this change, the loads can not be pushed when using pulled FEMeshes

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Ep2YzfY1pTBPlgeleEeDt78BVizKMSA7XCPgXqg6V-xZuA?e=zQRGvI

Changelog

Additional comments

IsakNaslundBh commented 3 years ago

@BHoMBot check installer

bhombot-ci[bot] commented 3 years ago

@IsakNaslundBh to confirm, `check-installer` task is now queued.

FraserGreenroyd commented 3 years ago

To confirm, this PR has been discussed between @IsakNaslundBh and myself and has been approved for merge during PR freeze to be included in the beta as this resolves a bug found during beta testing :smile: