BHoM / GSA_Toolkit

GSA tools and methods for use in other applications and repositories
GNU Lesser General Public License v3.0
5 stars 2 forks source link

Tweaks to get GSA ready for altconfigs in installers. #268

Closed IsakNaslundBh closed 2 years ago

IsakNaslundBh commented 2 years ago

Issues addressed by this PR

Get GSA ready for inclusion in installers

Link to installer: https://burohappold.sharepoint.com/:f:/s/BHoM/EvGchF7-ctJCvjYPf76uG2ABbViKvnThhddyo4-Y-_770g?e=jNZKA4

Rename GSA_10_1Adapter to GSA101Adapter to match what is done elsewhere Rename GSA_8_7Adatper to GSA87Adapter to match what is done elsewhere Add versioning to accommodate the above Add versioning from GSAAdapter -> GSA87Adapter as GSAAdapter wont be part of installers as soon as altconfigs start building. The previous the Debug build behaves as the Debug87 build (same for release) so an upgrade to GSA87Adapter should give the same behaviour for old scripts. If a script should start targeting GSA10.1, a change of adapter is required, but this should be expected as it is a new target.

Test files

Running of installers produced by installer PRs and ensuring that GSA87Adapter and GSA101Adapters exists. Opening old scripts with GSAAdapter present and make sure they are updated to GSA87ADapter and functions as before. Opening old scripts with GSA_10_1Adapter making sure they are correctly versioned and functions.

Changelog

Additional comments

bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer
IsakNaslundBh commented 2 years ago

@BHoMBot check core @BHoMBot check versioning

IsakNaslundBh commented 2 years ago

@BHoMBot check core @BHoMBot check versioning please

FraserGreenroyd commented 2 years ago

@BHoMBot pretty please can you check core for me?

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `core`
IsakNaslundBh commented 2 years ago

@BHoMBot pretty pretty please check versioning for me. That would be great thanks!

IsakNaslundBh commented 2 years ago

@BHoMBot check versioning

bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `versioning`
IsakNaslundBh commented 2 years ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer
IsakNaslundBh commented 2 years ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer
bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer
bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer
bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer
bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer
IsakNaslundBh commented 2 years ago

@BHoMBot check compliance @BHoMBot check required

bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 2 years ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 years ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 years ago
The check `project-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 years ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 2 years ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge`