BHoM / GSA_Toolkit

GSA tools and methods for use in other applications and repositories
GNU Lesser General Public License v3.0
5 stars 2 forks source link

Read load combination with parantheses #283

Closed johannaisak closed 1 year ago

johannaisak commented 1 year ago

Added if statement that replaces for example "1.5(L1 + L2)" with "1.5L1 + 1.5L2" when reading load combinations. There is probably a cleverer way of coding this?!

Please check that this works if you open the model in GSA 10.1 too.

NOTE: Depends on

Issues addressed by this PR

Closes #282

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23283-Read-load-combinations-with-parantheses?csf=1&web=1&e=oeKcYD

Changelog

Additional comments

johannaisak commented 1 year ago

@BHoMBot check compliance @BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@johannaisak to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 15 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge` There are 5 requests in the queue ahead of you.