search

BHoM / GSA_Toolkit

GSA tools and methods for use in other applications and repositories
GNU Lesser General Public License v3.0
5 stars 2 forks source link

Read thickness fix #286

Closed johannaisak closed 1 year ago

johannaisak commented 1 year ago

Handles if thickness is written as number or number(unit) for both GSA10.1 and GSA 8.7

NOTE: Depends on

Issues addressed by this PR

Closes #285

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23286-Pull-FE-meshes-in-GSA101?csf=1&web=1&e=YH3NIy

Changelog

Additional comments

FraserGreenroyd commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 1 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `core` - check `null-handling` - check `serialisation` There are 1 requests in the queue ahead of you.
FraserGreenroyd commented 1 year ago

@BHoMBot check versioning @BHoMBot check installer

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning` - check `installer` There are 15 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
Please be advised that the check with reference 12110963219 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 300 additional annotations waiting, made up of 300 errors and 0 warnings.
FraserGreenroyd commented 1 year ago

@BHoMBot check installer

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `installer`
FraserGreenroyd commented 1 year ago

@BHoMBot check installer

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `installer`
FraserGreenroyd commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 114 requests in the queue ahead of you.
Chrisshort92 commented 1 year ago

@FraserGreenroyd can you merge this PR please?