BHoM / GSA_Toolkit

GSA tools and methods for use in other applications and repositories
GNU Lesser General Public License v3.0
5 stars 2 forks source link

Changed which enum UnitType to use for NodeDisplacements #290

Closed TosteSkDa closed 1 year ago

TosteSkDa commented 1 year ago

Changed what UnitType (LENGTH to DISP) was being used when pulling node displacements from GSA to fix bug where results were pulled in mm instead of m.

NOTE: Depends on

Issues addressed by this PR

Closes #289

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23290-read-node-displacements-gives-wrong-unit?csf=1&web=1&e=BJnL5s

Changelog

Additional comments

IsakNaslundBh commented 1 year ago

@BHoMBot check compliance @BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 1 year ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 1 year ago

@BHoMBot check versioning

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `versioning`
IsakNaslundBh commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge`