7.1 Deployment

[bhombot-ci[bot]]

GSA_Toolkit

Compliance

• Align with rename StartNode/EndNode to Start/End
• Update AssemblyFileVersion to 7.1
• Update Copyright Headers to 2024

  Documentation

• Update readme link

[Artem-Holstov]

Version tested: 7.1.0.240318 (again not shown correctly in GH, which instead keeps showing 6.3 despite the latest version installed)

Review summary: Tests 1-4 and 9 + two scripts from recent projects run as previously. New issues found when pushing loading data into GSA in test 2. These may relate to the changes to the naming of bar parameters. Overall, we have a number of things not working in the tests, including the new errors, but the scripts I am using in active projects still run fine, because I am not currently using the functions that do not work.

New error message: When pushing certain types of bar loading (bar differential temperature, area temperature load, area differential temperature load, point acceleration, point velocity, contour load and geometrical line load), we now get the following message:

• Error: The best overloaded method match for 'BH.Adapter.GSA.Convert.Factor(BH.oM.Structure.Loads.PointLoad, double[])' has some invalid arguments
• Occured in BH.Adapter.GSA.Convert.IFactor(ILoad load, Double[] unitType) called from BH.Adapter.GSA.Convert.ToGsaString(IElementLoad`1 barLoad, Double[] unitFactors)
• Are you sure you have The correct type of inputs? Check their description for more details.

Other comments: Most errors identified in testing of v7.0 remained. A small number of errors in test 3 seem to have been resolved. These include the following ones, which are NO LONGER THERE when pushing sections into GSA:

1. Material with id 1 and name TestAluminium is of a type not currently fully supported or has no type defined. A generic isotropic material will be assumed
2. Material with id 2 and name TestTimber is of a type not currently fully supported or has no orthotropic type defined. A generic orthotropic material will be assumed

[FraserGreenroyd]

@BHoMBot check compliance

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 34 requests in the queue ahead of you.

[Artem-Holstov]

Version tested: 7.1.0.240324 (not shown correctly in GH, which instead keeps showing 6.3 despite the latest version installed), including updates applied after the previous review

Review summary: Tests 1-4 and 9 + two scripts from recent projects run as previously. No new issues found compared to version v7.1. Previously unhandled errors in test 2 are now caught and useful warnings are provided relating to the missing functionality of the GSA adapter (e.g. when pushing unsupported loading types).

Remaining issues: Tests 3 and 4 still have unhanded exceptions e.g. when pushing panels as meshes. This results in failure of the "push" component with a generic error message generated: "This component failed to run properly.

• Error: Object reference not set to an instance of an object.
• Occured in BH.Engine.Adapter.Query.AdapterId[T](IBHoMObject bHoMObject, Type adapterIdFragmentType, Boolean notFoundWarning) called from BH.Adapter.GSA.Convert.MaterialId(IMaterialFragment material)
• Are you sure you have the correct type of inputs? Check their description for more details." A similar approach to addressing this by catching the error and providing useful feedback can be applied in the next release.

Recommendation: This update addresses some of the previous issues without introducing new errors when pushing and pulling to GSA -> Approve and address the remaining issues in the future releases.

[FraserGreenroyd]

@BHoMBot check compliance

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 79 requests in the queue ahead of you.

[bhombot-ci[bot]]

@bhombot-ci[bot] just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on SQL_Toolkit

[bhombot-ci[bot]]

@bhombot-ci[bot] just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on SQL_Toolkit

[bhombot-ci[bot]]

@bhombot-ci[bot] just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

[bhombot-ci[bot]]

@bhombot-ci[bot] just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on SQL_Toolkit

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: null-handling, serialisation, dataset-compliance, unit-tests

[bhombot-ci[bot]]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core

[bhombot-ci[bot]]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

[bhombot-ci[bot]]

@bhombot-ci[bot] just to let you know, I have provided a `check-ready-to-merge` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM