BHoM / Geospatial_Toolkit

GNU Lesser General Public License v3.0
0 stars 1 forks source link

Add copyright to .cs files and assemblies to enable open sourcing #3

Closed al-fisher closed 3 years ago

al-fisher commented 3 years ago

Broken rules:

Before migrating this toolkit to BHoM org the copyright statements need to be correct

Suggestions to restore compliance:

As per snippet from open sourcing guidance in wiki - see below. Licence is already in place and correct from template, but copyrights need reviewing.

Licencing and copyright

  • Ensure repository has valid licence file.
    BHoM defaults to LGPL v3 https://github.com/BHoM/BHoM/blob/master/LICENSE.
    Repositories can be licenced differently, but by exception only and through agreement with BHoM Organisation Administrators. And would then require modifications to the repo's copyright headers in every code file.
  • All code files must have a valid BHoM copyright header compatible with licencing (see point above) See here for the default https://github.com/BHoM/BHoM/blob/master/COPYRIGHT_HEADER.txt
  • Assembly information and the included copyright must also conform to BHoM standards.
    Such as [assembly: AssemblyCopyright("Copyright © https://github.com/BHoM")]
FraserGreenroyd commented 3 years ago

Depending on the number of files that need copyright adding - BHoMBot can help with this if needed :smile:

rolyhudson commented 3 years ago

@FraserGreenroyd thanks only a few files. Another question - do the csproj files need switching to the new format to avoid down-the-line issues?

I noted some failing project compliance issues elsewhere which I am guessing are due to use of the old csproj format? https://github.com/BuroHappoldEngineering/Defra_Toolkit/pull/2

FraserGreenroyd commented 3 years ago

@rolyhudson looks like those errors will exist regardless of project format, as it's information about the references that are missing :smile:

FraserGreenroyd commented 3 years ago

That said, upgrading to the new format is being recommended if you're up for the new format!

al-fisher commented 3 years ago

This was carried out