BHoM / Grasshopper_UI

Tools for Grasshopper
GNU Lesser General Public License v3.0
16 stars 5 forks source link

ToString() method should use the Engine.Reflection.ToText method #406

Closed epignatelli closed 3 years ago

epignatelli commented 5 years ago

Description:

For each Goo, the ToString() method should use the Engine.Reflection.ToText method to enhance the way we display objects in panels.

For example, a Rhino point is displayed in a panel as {x, y, z}. We should do the same for the BHoM.

adecler commented 5 years ago

@epignatelli , I am not sure I follow your logic. Engine.reflection.ToText is currently used for things like Type and MethodBase, not actual instances of objects.

Agreed on the need to have a more centralised place to convert to string though (i.e. in the Engine) as we want this to be uniform across all UIs.

epignatelli commented 5 years ago

Yes, @adecler your second paragraph is the point of the issue. It doesn't have to be the ToText method, although it was the first thing I thought of.

epignatelli commented 5 years ago

Note the corresponding issue in the BhoM_Engine: https://github.com/BHoM/BHoM_Engine/issues/1189