BHoM / Grasshopper_UI

Tools for Grasshopper
GNU Lesser General Public License v3.0
16 stars 5 forks source link

Fix the pre-existing note messages covering the warnings #612

Closed adecler closed 3 years ago

adecler commented 3 years ago

Issues addressed by this PR

Closes #541

pre-existing messages are simply cleared from the component and reprocessed alongside any new event.

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/EaLHWrCr9NVBoz76ubs8DKwBoU2QMt6dd6j4IE8EsbRoug?e=rYww0U

You might have to change the path of the file you want to download if that one is not available for you. You will find that in the Create Download command...using a known File Full URL section of the script.

https://burohappold.sharepoint.com/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/Versioning_Toolkit/Versioning_Toolkit.gh

Changelog

Additional comments

adecler commented 3 years ago

@BHoMBot check all

bhombot-ci[bot] commented 3 years ago
@adecler to confirm, `check-code-compliance`, `check-documentation-compliance`, `check-project-compliance`, `check-branch-compliance`, `check-dataset-compliance`, if applicable `check-copyright-compliance`, `check-unit-tests`, `check-core`, `check-installer`, and `check-ready-to-merge` tasks are now queued.
adecler commented 3 years ago

@BHoMBot check ready to merge

bhombot-ci[bot] commented 3 years ago
@adecler sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to run? For example, if you would like me to run the `check-core` comment: _"@BHoMBot check core"_
bhombot-ci[bot] commented 3 years ago
@adecler sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to run? For example, if you would like me to run the `check-core` comment: _"@BHoMBot check core"_
bhombot-ci[bot] commented 3 years ago
@adecler sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to run? For example, if you would like me to run the `check-core` comment: _"@BHoMBot check core"_
bhombot-ci[bot] commented 3 years ago
@adecler sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to run? For example, if you would like me to run the `check-core` comment: _"@BHoMBot check core"_
bhombot-ci[bot] commented 3 years ago
@adecler sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to run? For example, if you would like me to run the `check-core` comment: _"@BHoMBot check core"_
adecler commented 3 years ago

@FraserGreenroyd , help please 😋

Not sure I see the point of that check is if I am honest. Isn't the PR allowed to merged only once it is approved by at least one person anyways ?

bhombot-ci[bot] commented 3 years ago
FAO: @FraserGreenroyd @adecler is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is check-ready-merge. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. `1966555912`