Noticing while removing several old create methods in https://github.com/BHoM/BHoM_Engine/pull/2738/files that some of them did not match up to the autogenerated creates. This seem to have to do with keys not identified on the side of GH.
Adding ToLower when scanning the properties seem to have fixed that issue. @adecler good for you to check this and that it does not go against the intention of the method
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine
@IsakNaslundBh just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine
@IsakNaslundBh just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine
@IsakNaslundBh just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine
@IsakNaslundBh to confirm, the following checks are now queued:
- `code-compliance`
- `documentation-compliance`
- `project-compliance`
- `branch-compliance`
- `dataset-compliance`
- `copyright-compliance`
- `code-compliance`
- `documentation-compliance`
- `project-compliance`
- `core`
- `null-handling`
- `serialisation`
- `versioning`
- `installer`
There are 121 requests in the queue ahead of you.
@IsakNaslundBh to confirm, the following checks are now queued:
- `code-compliance`
- `documentation-compliance`
- `project-compliance`
- `branch-compliance`
- `dataset-compliance`
- `copyright-compliance`
- `code-compliance`
- `documentation-compliance`
- `project-compliance`
- `core`
- `null-handling`
- `serialisation`
- `versioning`
- `installer`
There are 134 requests in the queue ahead of you.
NOTE: Depends on
Done in support of https://github.com/BHoM/BHoM_Engine/pull/2738/files but does not require that to compile.
Issues addressed by this PR
Noticing while removing several old create methods in https://github.com/BHoM/BHoM_Engine/pull/2738/files that some of them did not match up to the autogenerated creates. This seem to have to do with keys not identified on the side of GH.
Adding ToLower when scanning the properties seem to have fixed that issue. @adecler good for you to check this and that it does not go against the intention of the method
Test files
Changelog
Additional comments