BHoM / Grasshopper_UI

Tools for Grasshopper
GNU Lesser General Public License v3.0
16 stars 5 forks source link

Add null-check for request before checking SelectedItem on global search #676

Closed IsakNaslundBh closed 1 year ago

IsakNaslundBh commented 1 year ago

Issues addressed by this PR

Closes #675

Adding simple null-check on request before trying to access SelectedItem. See issue as to why/when this has been slightly annoying issue.

Test files

Global search should still work.

Changelog

Additional comments

Cannot really see how this could have a negative impact on anything, but glad for a quick look @adecler

IsakNaslundBh commented 1 year ago

@BHoMBot check compliance @BHoMBot check required

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 1 year ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
IsakNaslundBh commented 1 year ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 1 year ago
@IsakNaslundBh to confirm, the following actions are now queued: - check `ready-to-merge`