BHoM / Grasshopper_UI

Tools for Grasshopper
GNU Lesser General Public License v3.0
15 stars 4 forks source link

Fix missing internalised data when method component is versioned #696

Closed adecler closed 6 months ago

adecler commented 6 months ago

Issues addressed by this PR

Closes #647

Test files

Step 1

Create a Point component (the one from the method): image

Step 2

Internalise some data in the x input parameter and save the file: image

Step 3

Edit the code for the Create.Point method like so (i.e. change the first input to a): image

Step 4

Recompile the BHoM_Engine and the Versioning_Toolkit

Step 5

Re=open the file and make sure that the internalised data is still there: image

Changelog

Additional comments

FraserGreenroyd commented 6 months ago

@BHoMBot check versioning @BHoMBot check compliance

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `versioning` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 20 requests in the queue ahead of you.
FraserGreenroyd commented 6 months ago

@BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `core` - check `null-handling` - check `serialisation` There are 42 requests in the queue ahead of you.
FraserGreenroyd commented 6 months ago

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.
FraserGreenroyd commented 6 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation be granted on check ref. 20394491325

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd I'm sorry, but I am not authorised to take that instruction from you.
FraserGreenroyd commented 6 months ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 20394491325

FraserGreenroyd commented 6 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 73 requests in the queue ahead of you.
bhombot-ci[bot] commented 6 months ago
@FraserGreenroyd I have now provided a passing check on reference `20394491325` as requested.