search

BHoM / LifeCycleAssessment_Toolkit

GNU Lesser General Public License v3.0
22 stars 5 forks source link

Removes default description values for LCAScope component #222

Closed maryannewachter closed 3 years ago

maryannewachter commented 3 years ago

Issues addressed by this PR

Closes #221 Closes #225 Closes #226

Test files

Test File

Changelog

Additional comments

Please review changed text for consistency with rest of toolkit.

maryannewachter commented 3 years ago

@bhombot check installer

bhombot-ci[bot] commented 3 years ago
@maryannewachter to confirm, `check-installer` task is now queued.
bhombot-ci[bot] commented 3 years ago
@michaelhoehn sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to do? For a list of available instructions, please see [this wiki page](https://github.com/BHoM/documentation/wiki/Continuous-Integration).
michaelhoehn commented 3 years ago

@BHoMBot check core

michaelhoehn commented 3 years ago

@BHoMBot check installer

FraserGreenroyd commented 3 years ago

@BHoMBot don't ignore @michaelhoehn please, can you check core

bhombot-ci[bot] commented 3 years ago
@FraserGreenroyd to confirm, check `core` task is now queued.
michaelhoehn commented 3 years ago

@BHoMBot check core

bhombot-ci[bot] commented 3 years ago
@michaelhoehn to confirm, check `core` task is now queued.
michaelhoehn commented 3 years ago

@BHoMBot check installer

bhombot-ci[bot] commented 3 years ago
@michaelhoehn to confirm, check `installer` task is now queued.
michaelhoehn commented 3 years ago

@BHoMBot check versioning

bhombot-ci[bot] commented 3 years ago
@michaelhoehn to confirm, check `versioning` task is now queued.
michaelhoehn commented 3 years ago

@FraserGreenroyd any way we can disable these legacy check requirements so we can go for merge? The required checks have been reported but are under an updated name.

FYI @maryannewachter